changes made to publish to maven #11147
Conversation
|
@yzhliu @lanking520 could you please review this? Its blocking 1.2.1 release |
| if [[ $PLATFORM == "osx-x86_64-cpu" ]]; | ||
| then | ||
| echo "Building MXNet Backend on MAC OS" | ||
| echo "ADD_CFLAGS += -I/usr/local/opt/opencv@2/include" >> ./config.mk |
There was a problem hiding this comment.
Need to fix the opencv@2 here. Currently MXNet Python package use different openCV version
There was a problem hiding this comment.
Yes, lets fix this in the next iteration during release. I don't know at the moment what will work.
There was a problem hiding this comment.
Here is the issue to track #1119
| </scm> | ||
|
|
||
| <properties> | ||
| <scala.version>2.11.8</scala.version> | ||
| <scala.binary.version>2.11</scala.binary.version> | ||
| <build.platform /> |
There was a problem hiding this comment.
Why we have it here, it seemed empty?
There was a problem hiding this comment.
this is passed from the Makefile. ie., to say no default value
| make -j$(cat /proc/cpuinfo | awk '/^processor/{print $3}' | tail -1) | ||
| echo "Building MXNet Backend on Linux GPU" | ||
| else | ||
| echo "MY ALIEN OVERLOADS HAVE NOT TOLD WHAT TO DO FOR INVALID INPUT !!!" |
|
Thanks for your input, let's keep the issue tracked and solve that. @nswamy LGTM + 1 |
| @@ -30,12 +30,13 @@ | |||
| <connection>scm:git:git@github.com:apache/incubator-mxnet.git</connection> | |||
| <developerConnection>scm:git:git@github.com:apache/incubator-mxnet.git</developerConnection> | |||
| <url>https://github.com/apache/incubator-mxnet</url> | |||
| <tag>mxnet-parent_2.11-1.2.0</tag> | |||
| <tag>HEAD</tag> | |||
There was a problem hiding this comment.
Is this intended to point to the HEAD (master)?
There was a problem hiding this comment.
Yes, It has to create a new tag every time.
There was a problem hiding this comment.
I'm not very familiar with that setup, so please bare with me. What exactly is this supposed to do? I'd expect it to point to a certain branch, but this one would point to the master. What's the use-case here?
There was a problem hiding this comment.
Its just telling what tagName should be used when releasing. when HEAD it uses the name of the artifact defined in the pom file + version. We are not using this anyway, like I said on the email I have disabled tagging on the remote repo
|
@marcoabreu this one #11193 |
Description
Changes that were made to publish the packages to Maven, some of the changes were already committed by the Maven Release plugin on my behalf - I have disabled this functionality. Currently it will only create a tag on the local repo when you run release-prepare.
In brief.
apache-releaseprofile.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments